[MHLO] fix tensor mode aten.div op pattern #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the tensor mode aten.div op pattern; please review for me @silvasean @ZihengJiang @Vremold. Also, I found a bug in the |
tanyokwok
requested review from
silvasean,
Vremold,
ZihengJiang and
vivekkhandelwal1
ZihengJiang
approved these changes
Aug 5, 2022
|
LGTM! |
silvasean
approved these changes
Aug 5, 2022
Co-authored-by: Bairen Yi <yibairen.byron@bytedance.com> Co-authored-by: Jiawei Wu <xremold@gmail.com> Co-authored-by: Tianyou Guo <tianyou.gty@alibaba-inc.com> Co-authored-by: Xu Yan <yancey.yx@alibaba-inc.com> Co-authored-by: Ziheng Jiang <ziheng.jiang@bytedance.com>
tanyokwok
force-pushed
the
tanyo/fix_torch_floor_divide
branch
from
2333621
to
b8113b3
Compare
ZihengJiang
reviewed
Aug 10, 2022
| // to C-style integer division. | ||
| auto sign = rewriter.create<mhlo::SignOp>(loc, result); | ||
| auto abs = rewriter.create<mhlo::AbsOp>(loc, result); | ||
| auto floor = rewriter.create<mhlo::FloorOp>(loc, abs); |
There was a problem hiding this comment.
mhlo.floor only supports float, so this will rase error when lowering div.Tensor_mode on two integers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See RFC #999
Co-authored-by: Bairen Yi yibairen.byron@bytedance.com
Co-authored-by: Jiawei Wu xremold@gmail.com
Co-authored-by: Tianyou Guo tianyou.gty@alibaba-inc.com
Co-authored-by: Xu Yan yancey.yx@alibaba-inc.com
Co-authored-by: Ziheng Jiang ziheng.jiang@bytedance.com